Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add plastic.desktop file to release #44

Closed
wants to merge 3 commits into from

Conversation

marcelarie
Copy link

@marcelarie marcelarie commented Nov 8, 2024

This PR adds package/plastic.desktop to the release to ensure it's available as a source in the PKGBUILD, following the discussion in issue #31 about including the .desktop file and logo in the Arch packages.

CC: @orhun

@Amjad50
Copy link
Owner

Amjad50 commented Nov 8, 2024

I don't think this is where you want to edit (also there is a typo in desktop).

This adds it to the release artifact, which includes the Deb file which has the desktop inside it anyway.

From what I understand the arch pkgbuild file uses the source pushed in crates.io, and thus, we need to change Cargo.toml to include them.

Though I'm not sure on this, can you confirm @orhun ?

@marcelarie
Copy link
Author

I don't think this is where you want to edit (also there is a typo in desktop).

Go it, it is the first time that I work with Arch packages, sorry for the noise. I wait for the reply of @orhun to see if he knows better and if not I find an alternative.

@marcelarie
Copy link
Author

marcelarie commented Nov 8, 2024

I did a test locally before and it worked, idk how because it had the typo. Now that is fixed, and I did another test with a testing release from my fork and it works.

You can see the app is available, and the icon moved, here:
satty-20241108-19:34:25
satty-20241108-19:35:03

Copy link
Contributor

@silverhadch silverhadch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. However dont forget the Manpage in the package.

@silverhadch
Copy link
Contributor

I did a test locally before and it worked, idk how because it had the typo. Now that is fixed, and I did another test with a testing release from my fork and it works.

You can see the app is available, and the icon moved, here:
satty-20241108-19:34:25
satty-20241108-19:35:03

Try it in a VM please thats how i test my debian packages.

@marcelarie marcelarie changed the title Fix: Add package.desktop file to release Fix: Add plastic.desktop file to release Nov 11, 2024
@orhun
Copy link
Contributor

orhun commented Nov 12, 2024

Adding the desktop file to the repo in #40 was enough for the Arch package. Adding it to the releases is optional :)

@Amjad50
Copy link
Owner

Amjad50 commented Nov 12, 2024

Adding the desktop file to the repo in #40 was enough for the Arch package. Adding it to the releases is optional :)

Alright, I guess then you just need to update the arch pkgbuild to install those files

@orhun
Copy link
Contributor

orhun commented Nov 12, 2024

yup

@Amjad50
Copy link
Owner

Amjad50 commented Nov 12, 2024

Alright, then no need to add it to the release package specifically.
These files are already part of the deb file.

I'll close this PR, but thanks for bringing this up and fixing the arch recipe.

The arch recipe uses the files from source directly, reference to the PR for Arch: https://gitlab.archlinux.org/archlinux/packaging/packages/plastic/-/merge_requests/1

@Amjad50 Amjad50 closed this Nov 12, 2024
@marcelarie
Copy link
Author

Alright, then no need to add it to the release package specifically. These files are already part of the deb file.

I'll close this PR, but thanks for bringing this up and fixing the arch recipe.

The arch recipe uses the files from source directly, reference to the PR for Arch: https://gitlab.archlinux.org/archlinux/packaging/packages/plastic/-/merge_requests/1

Hi, I created the other PR that points to the source directly, but the files are not available in the release without these changes, as far as I know.

@Amjad50
Copy link
Owner

Amjad50 commented Nov 12, 2024

Using the release package as its doing here is a workaround, the solution is to release a new version of plastic, the issue is that the arch package uses v0.3.1 which doesn't have the new files

I'll release a new version, I thought I'll delay it to work on some features, but I'll do it now.

@marcelarie
Copy link
Author

marcelarie commented Nov 12, 2024

Got it! Thanks for the explanation, now its more clear.

@Amjad50
Copy link
Owner

Amjad50 commented Nov 12, 2024

Released 0.3.4, please use this as the source for the arch recipe, and you don't need to add the individual files as sources.

@marcelarie
Copy link
Author

@Amjad50 I tried it with the new release and it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants